Add pre-confirmation trade fee estimate - #390
Merged
Chucks1093 merged 2 commits intoMay 31, 2026
Merged
Conversation
|
@T-kesh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pre-confirmation network fee estimate to the trade dialog so users can see an approximate cost before confirming a buy or sell. The trade flow now fetches live fee data through the ethers provider, formats the estimate with an explicit “Approx. network fee” label, and falls back to a clear “Cannot estimate network fee” message when fee data cannot be fetched. Focused dialog tests were added for both the successful estimate and failure states. Tests were not run locally because dependency installation failed earlier due to ERR_PNPM_ENOSPC disk space exhaustion.
closes #382